Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4162/4/fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java File fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java: Line 197: if (insertStmt.hasNoShuffleHint()) return inputFragment; i find this easier to read than the 3-valued "flag" from before Line 249: DataPartition partition = DataPartition.hashPartitioned(partitionExprs); change this c'tor to return an unpartitioned DataPartition if the expr list is empty? -- To view, visit http://gerrit.cloudera.org:8080/4162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1084d49c95b7d867eeac3297fd2016daff0ab687 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
