Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4182/1/be/src/exec/row-batch-list-test.cc File be/src/exec/row-batch-list-test.cc: Line 122: DCHECK_EQ(ALLOC_SIZE, batch->tuple_data_pool()->total_allocated_bytes()); > let's also check that the batch from L110 has no allocated bytes in its tup Done http://gerrit.cloudera.org:8080/#/c/4182/1/be/src/exec/row-batch-list.h File be/src/exec/row-batch-list.h: Line 88 > ouch :( Yep, looks like it's been here since the old cross join node was added. Line 61: /// Increments the iterator. No-op if the iterator is at the end. > Moves the iterator to the next non-empty row batch... Worded slightly differently - can you check if it makes sense. -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb19e536b87bbb4d4ae82d1636ba1463a422789 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
