Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4049: fix empty batch handling NLJ build side ......................................................................
IMPALA-4049: fix empty batch handling NLJ build side Memory from the build side of a nested loop join is referenced by its output batches, so accumulated memory build side resources must be transferred to the caller. Special-cased handling of empty batches did not transfer the memory. The fix is to accumulate empty batches and transfer their resources in the same way as non-empty batches. The iterator required changes to handle empty batches in the list. Testing: Added a unit test that exercises the bug RowBatchList. Add a query test that causes a crash in the ASAN build and incorrect results in the debug build. Change-Id: I3cb19e536b87bbb4d4ae82d1636ba1463a422789 Reviewed-on: http://gerrit.cloudera.org:8080/4182 Reviewed-by: Matthew Jacobs <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/row-batch-list-test.cc M be/src/exec/row-batch-list.h M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch.test 3 files changed, 58 insertions(+), 5 deletions(-) Approvals: Matthew Jacobs: Looks good to me, but someone else must approve Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cb19e536b87bbb4d4ae82d1636ba1463a422789 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
