Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side ......................................................................
Patch Set 2: (1 comment) It seems like it would be very difficult to trigger without a subplan, but it's a bit strange we didn't see it sooner after we introduced nested types. http://gerrit.cloudera.org:8080/#/c/4182/2/be/src/exec/row-batch-list.h File be/src/exec/row-batch-list.h: PS2, Line 82: while (!AtEnd() && (*batch_it_)->num_rows() == 0) ++batch_it_; > not a big deal, but what about making this "SkipEmptyBatches()" and calling Done -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb19e536b87bbb4d4ae82d1636ba1463a422789 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
