Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 11: Code-Review+2 (5 comments) http://gerrit.cloudera.org:8080/#/c/4066/10/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 2110: DCHECK_EQ(state->bloom_filter(), reinterpret_cast<TBloomFilter*>(NULL)); move this todo http://gerrit.cloudera.org:8080/#/c/4066/11/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 281: you can remove all blank lines between the getters Line 380: // TODO-MT: remove > Can you remove this comment? there shouldn't be references to any query-related state when the QueryState refcount goes to 0. why would this still be necessary? Line 2098: // Complete partitioned or broadcast join filter case. "complete filter case" Line 2133: //if (desc_.is_broadcast_join) return; remove -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
