Tim Armstrong has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4066/11/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 380: // TODO-MT: remove > there shouldn't be references to any query-related state when the QueryStat MemUsageHandler() in default-path-handlers.cc could be in the process of walking the process-wide MemTracker tree top-down. If it gets a reference to the query MemTracker just before QueryExecState is torn down, then it could walk the child link to filter_mem_tracker_ after filter_mem_tracker_ is destroyed. Acquiring child_trackers_lock_ in UnregisterFromParent() prevents this race. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
