Jim Apple has posted comments on this change. Change subject: IMPALA-3399: Add DITA Open Toolkit to build Impala user docs. ......................................................................
Patch Set 1: > I think we can avoid making this part of native-toolchain since it > looks like pure Java code that doesn't depend on any other parts of > the toolchain and isn't platform-dependent. I was adding this to the toolchain not only for platform-dependency issues, but also to make it easy for toolchain users to get all of the tools needed for build and test. Also, I imagine it might depend on your JDK, which one might consider part of the platform. > This would also make the native toolchain dependent on Gradle, > which I believe will download things from the internet, rather than > just our S3 source buckets. Yeah, that's not great. Once we decide where to put this, I will try to fix that with "./gradlew dist". > How about we just add the build script to the Impala repository? I > could see hosting the source on S3 but it might also be good to > support building directly from the original github tag. Maybe it should be part of https://github.com/awleblang/impala-setup? It seems like that's where the rest of the scripts to download and install third-party dependencies are, other than this Toolchain repo. -- To view, visit http://gerrit.cloudera.org:8080/4902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1110b8c8dc5a9333143055afd49734fc336a1f0 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
