Tim Armstrong has posted comments on this change. Change subject: IMPALA-3399: Add DITA Open Toolkit to build Impala user docs. ......................................................................
Patch Set 1: > I don't understand how this patch conflates them. It's building code that's not C/C++ and isn't self-contained (since it pulls down binary artifacts rather than building from source). I don't think Kudu fully meets those criteria, unfortunately, but that's a separate issue. > Not the system JDK? Why not? We generally build Impala with a fixed JDK version on all platforms (Oracle JDK 7). I think this makes more sense (and the compiled JARs should be the same independent of platform). > Is "it" dita-ot Yeah. I mean it seems most useful if we have this helper script in the same place as the other doc build scripts (that would make it easier to automate doc builds I think). -- To view, visit http://gerrit.cloudera.org:8080/4902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1110b8c8dc5a9333143055afd49734fc336a1f0 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
