Tim Armstrong has posted comments on this change. Change subject: IMPALA-3399: Add DITA Open Toolkit to build Impala user docs. ......................................................................
Patch Set 1: My feeling is that we need to clearly distinguish between the native-toolchain as a system for building native dependencies from source in a self-contained reproducible way, and the S3 buckets as a delivery mechanism. I don't think they're the same thing and I think conflating them will cause problems. native-toolchain should not require any Java compilers. It's just coincidence that one was available on the systems that it was built on because those VM images are prepopulated with various JDKs. We need to have a JDK for the Impala build (which is not the system JDK), so I think that actually is an argument to build it in the Impala repository, which is the only step of the build now that requires a JDK to be present. I also think it would be a mistake to start treating the impala-setup repository as an essential build step instead of a convenience. What's the vision for the docs build? Will it be part of the Impala source repoo? -- To view, visit http://gerrit.cloudera.org:8080/4902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1110b8c8dc5a9333143055afd49734fc336a1f0 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
