kr11 commented on a change in pull request #34: fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/34#discussion_r251227499
##########
File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBQueryResultSet.java
##########
@@ -726,7 +730,7 @@ public boolean next() throws SQLException {
if (maxRowsOrRowsLimit > 0 && rowsFetched >= maxRowsOrRowsLimit) {
// The constraint of maxRows instead of rowsLimit is embodied
if (rowsLimit == 0 || (maxRows > 0 && maxRows < rowsLimit)) {
- System.out.println("Reach max rows " + maxRows);
+ LOGGER.info("Reach max rows " + maxRows);
Review comment:
I agree this log may only help developers, but not users, could we use
`debug` level? @MyXOF
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services