kr11 commented on a change in pull request #34: fix sonar 
URL: https://github.com/apache/incubator-iotdb/pull/34#discussion_r251230865
 
 

 ##########
 File path: 
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/DeltaBinaryDecoder.java
 ##########
 @@ -34,9 +28,8 @@
  * @author kangrong
  * @see DeltaBinaryEncoder
  */
-public abstract class DeltaBinaryDecoder extends Decoder {
+public abstract class DeltaBinaryDecoder<T> extends Decoder {
 
 Review comment:
   The generic class is the primary designing and then we split it into 
`IntDeltaDecoder` and `LongDeltaDecoder` for efficiency. 
   An efficiency evaluation is required before changing it back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to