kr11 commented on a change in pull request #34: fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/34#discussion_r251230020
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/common/conf/TSFileDescriptor.java
##########
@@ -53,7 +49,7 @@ public TSFileConfig getConfig() {
return conf;
}
- private void multiplicityWarning(String resource, ClassLoader classLoader) {
+ private static void multiplicityWarning(String resource, ClassLoader
classLoader) {
Review comment:
`TsFileDesciptor` is written with the `Singleton pattern` after a lot of
discussions. Be very careful to modify the function to the static method.
If we are sure to change them to static functions, `private TSFileConfig
conf` and `getInstance()` can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
