Hi Chris,

I checked the binary distribution, and didn't find the problem.

You can run "mvn clean package -Papache-release -DskipTests" in the root folder 
and get an "apache-iotdb-0.8.0-SNAPSHOT-incubatin-bin.zip" in the target under 
the root.

The structure of this zip file is as follow and it works well (by 
./sbin/start-server.sh and ./sbin/start-client.sh):

.
├── DISCLAIMER
├── LICENSE-binary
├── NOTICE-binary
├── README.md
├── RELEASE_NOTES.md
├── conf
│   ├── iotdb-engine.properties
│   ├── iotdb-env.bat
│   ├── iotdb-env.sh
│   ├── iotdb-sync-client.properties
│   ├── logback-tool.xml
│   ├── logback.xml
│   └── tsfile-format.properties
├── docs
│   ├── Community-History&Vision.md
│   ├── Community-Powered\ By.md
│   ├── Community-Project\ Committers.md
│   ├── Development.md
│   ├── Documentation
│   │   ├── Frequently\ asked\ questions.md
│   │   ├── OtherMaterial-Examples.md
│   │   ├── OtherMaterial-Reference.md
│   │   ├── OtherMaterial-Sample\ Data.md
│   │   ├── OtherMaterial-Sample\ Data.txt
│   │   ├── QuickStart.md
│   │   └── UserGuide
│   │       ├── 0-Content.md
│   │       ├── 1-Overview
│   │       │   ├── 1-What\ is\ IoTDB.md
│   │       │   ├── 2-Architecture.md
│   │       │   ├── 3-Scenario.md
│   │       │   └── 4-Features.md
│   │       ├── 2-Concept\ Key\ Concepts\ and\ Terminology
│   │       │   ├── 1-Key\ Concepts\ and\ Terminology.md
│   │       │   ├── 2-Data\ Type.md
│   │       │   ├── 3-Encoding.md
│   │       │   └── 4-Compression.md
│   │       ├── 3-Operation\ Manual
│   │       │   ├── 1-Sample\ Data.md
│   │       │   ├── 2-Data\ Model\ Selection.md
│   │       │   ├── 3-Data\ Import.md
│   │       │   ├── 4-Data\ Query.md
│   │       │   ├── 5-Data\ Maintenance.md
│   │       │   └── 6-Priviledge\ Management.md
│   │       ├── 4-Deployment\ and\ Management
│   │       │   ├── 1-Deployment.md
│   │       │   ├── 2-Configuration.md
│   │       │   ├── 3-System\ Monitor.md
│   │       │   ├── 4-Performance\ Monitor.md
│   │       │   ├── 5-System\ log.md
│   │       │   ├── 6-Data\ Management.md
│   │       │   └── 7-Build\ and\ use\ IoTDB\ by\ Dockerfile.md
│   │       ├── 5-IoTDB\ SQL\ Documentation
│   │       │   ├── 1-IoTDB\ Query\ Statement.md
│   │       │   └── 2-Reference.md
│   │       ├── 6-JDBC\ API
│   │       │   └── 1-JDBC\ API.md
│   │       ├── 7-TsFile
│   │       │   ├── 1-Installation.md
│   │       │   ├── 2-Usage.md
│   │       │   └── 3-Hierarchy.md
│   │       ├── 8-System\ Tools
│   │       │   ├── 1-Sync.md
│   │       │   └── 2-Memory\ Estimation\ Tool.md
│   │       ├── 8-Tools-Cli.md
│   │       ├── 8-Tools-Grafana.md
│   │       ├── 8-Tools-Hadoop.md
│   │       └── 8-Tools-spark.md
│   └── Documentation-CHN
│       ├── Frequently\ asked\ questions.md
│       ├── OtherMaterial-Examples.md
│       ├── OtherMaterial-Reference.md
│       ├── QuickStart.md
│       └── UserGuide
│           ├── 1-Overview
│           │   ├── 1-What\ is\ IoTDB.md
│           │   ├── 2-Architecture.md
│           │   ├── 3-Scenario.md
│           │   └── 4-Features.md
│           ├── 2-Concept\ Key\ Concepts\ and\ Terminology
│           │   ├── 1-Key\ Concepts\ and\ Terminology.md
│           │   ├── 2-Data\ Type.md
│           │   ├── 3-Encoding.md
│           │   └── 4-Compression.md
│           ├── 3-Operation\ Manual
│           │   ├── 1-Sample\ Data.md
│           │   ├── 2-Data\ Model\ Selection.md
│           │   ├── 3-Data\ Import.md
│           │   ├── 4-Data\ Query.md
│           │   ├── 5-Data\ Maintenance.md
│           │   └── 6-Priviledge\ Management.md
│           ├── 4-Deployment\ and\ Management
│           │   ├── 1-Deployment.md
│           │   ├── 2-Configuration.md
│           │   ├── 3-System\ Monitor.md
│           │   ├── 4-Performance\ Monitor.md
│           │   ├── 5-System\ log.md
│           │   ├── 6-Data\ Management.md
│           │   └── 7-Build\ and\ use\ IoTDB\ by\ Dockerfile.md
│           ├── 5-IoTDB\ SQL\ Documentation
│           │   ├── 1-IoTDB\ Query\ Statement.md
│           │   └── 2-Reference.md
│           ├── 6-JDBC\ API
│           │   └── 1-JDBC\ API.md
│           ├── 7-TsFile
│           │   ├── 1-Installation.md
│           │   ├── 2-Usage.md
│           │   └── 3-Hierarchy.md
│           ├── 8-System\ Tools
│           │   ├── 1-Sync.md
│           │   └── 2-Memory\ Estimation\ Tool.md
│           ├── 8-Tools-Cli.md
│           ├── 8-Tools-Grafana.md
│           ├── 8-Tools-Hadoop.md
│           └── 8-Tools-spark.md
├── lib
│   ├── FastInfoset-1.2.14.jar
│   ├── airline-0.8.jar
│   ├── antlr-runtime-3.5.2.jar
│   ├── byte-buddy-1.9.3.jar
│   ├── byte-buddy-agent-1.9.3.jar
│   ├── commons-cli-1.3.1.jar
│   ├── commons-collections4-4.0.jar
│   ├── commons-io-2.5.jar
│   ├── commons-lang3-3.1.jar
│   ├── commons-lang3-3.8.1.jar
│   ├── fastjson-1.2.31.jar
│   ├── guava-21.0.jar
│   ├── hamcrest-core-1.3.jar
│   ├── iotdb-client-0.8.0-SNAPSHOT.jar
│   ├── iotdb-jdbc-0.8.0-SNAPSHOT.jar
│   ├── iotdb-server-0.8.0-SNAPSHOT.jar
│   ├── istack-commons-runtime-3.0.6.jar
│   ├── jansi-1.17.1.jar
│   ├── javassist-3.24.0-GA.jar
│   ├── javax.activation-api-1.2.0.jar
│   ├── javax.annotation-api-1.3.2.jar
│   ├── javax.inject-1.jar
│   ├── jaxb-api-2.4.0-b180725.0427.jar
│   ├── jaxb-runtime-2.4.0-b180725.0644.jar
│   ├── jline-2.14.5.jar
│   ├── jline-3.10.0.jar
│   ├── jsr305-3.0.2.jar
│   ├── junit-4.12.jar
│   ├── libthrift-0.9.3.jar
│   ├── logback-classic-1.1.11.jar
│   ├── logback-core-1.1.11.jar
│   ├── mockito-all-1.10.19.jar
│   ├── mockito-core-2.23.0.jar
│   ├── objenesis-3.0.1.jar
│   ├── powermock-api-mockito2-2.0.2.jar
│   ├── powermock-api-support-2.0.2.jar
│   ├── powermock-core-2.0.2.jar
│   ├── powermock-module-junit4-2.0.2.jar
│   ├── powermock-module-junit4-common-2.0.2.jar
│   ├── powermock-reflect-2.0.2.jar
│   ├── progressbar-0.7.3.jar
│   ├── service-rpc-0.8.0-SNAPSHOT.jar
│   ├── slf4j-api-1.7.12.jar
│   ├── slf4j-api-1.7.22.jar
│   ├── snappy-java-1.0.5-M1.jar
│   ├── stax-ex-1.8.jar
│   ├── tsfile-0.8.0-SNAPSHOT.jar
│   └── txw2-2.4.0-b180725.0644.jar
├── licenses
│   ├── CDDL\ License\ 1.1
│   ├── EDL\ License\ 1.0
│   ├── Eclipse\ Public\ License\ 1.0\ (EPL-1.0)
│   ├── Eclipse\ Public\ License\ version\ 2.0\ (EPL-2.0)
│   ├── The\ 2-Clause\ BSD\ License
│   ├── The\ 3-Clause\ BSD\ License
│   └── The\ MIT\ License
├── sbin
│   ├── start-client.bat
│   ├── start-client.sh
│   ├── start-server.bat
│   ├── start-server.sh
│   ├── stop-server.bat
│   └── stop-server.sh
└── tools
    ├── export-csv.bat
    ├── export-csv.sh
    ├── import-csv.bat
    ├── import-csv.sh
    ├── memory-tool.bat
    ├── memory-tool.sh
    ├── start-WalChecker.bat
    ├── start-WalChecker.sh
    ├── start-sync-client.bat
    ├── start-sync-client.sh
    ├── stop-sync-client.bat
    └── stop-sync-client.sh


Thanks,
--
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院

> -----原始邮件-----
> 发件人: "Christofer Dutz" <[email protected]>
> 发送时间: 2019-07-27 23:15:25 (星期六)
> 收件人: "[email protected]" <[email protected]>
> 抄送: 
> 主题: Re: [VOTE] Apache IoTDB (Incubating) 0.8.0 RC1
> 
> I intentionally didn’t read all the other vote emails as I wanted to do this 
> unbiassed … so please forgive for repeating to report things.
> 
> 
> 
> +1 (for the source-release) / -1 for the binary distribution (binding)
> 
> 
> 
> The source-release looks quite good (except the version set in the “hadoop” 
> module and some minor issues)
> 
> The binary distribution looks empty … it doesn’t seem to contain any jars at 
> all … guess this is not how it should be?
> 
> 
> 
> 
> 
> 
> 
> Details:
> 
> 
> 
>   *   Signatures (ASC) (src and bin) ok and relate to apache email address: OK
>   *   SHA512 hashes match (src and bin): OK
>   *   Source Bundle:
>      *   LICENSE, NOTICE, README, RELEASE_NOTES exist in source bundle: OK 
> (However I would prefer the binary versions not to be included)
>      *   check the contents of LICENSE, NOTICE, README.md, RELEASE_NOTES.md
>         *   LICENSE: Path of MavenDownloaderWrapper.java is wrong
>         *   NOTICE: Year in the notice could need updating … we’re no longer 
> 2018
>         *   NOTICE: IANAL but: I don’t think the source bundle actually 
> includes crypto code. If it’s just a dependency, it doesn’t need to be listed.
>         *   NOTICE: What does the “SE” in “an open-source Java SE” mean? 
> Should this be “SW” or better “software”?
>         *   README.md: When building a Java JRE might not be enough … a JDK 
> could be required (Not checked)
>         *   README.md: Should add the possibility of downloading the source 
> bundle from the website
>         *   README.md: The structure of the project isn’t as described in the 
> file (Line 84ff)
>         *   README.md: Couldn’t find bin/start-server.sh or .bat (Line 104ff) 
> same applies for the start-client.sh or .bat
>         *   README.md: Could not build according to maven command as there is 
> no “iotdb” module (After a check in the history, I noticed there was some 
> renaming … used “server” instead and that worked).
>         *   README.md: Build output looks different due to renaming (Line 
> 130ff)
>         *   REDEME.md: Structure of output looks different (server/iotdb 
> instead of iotdb/iotdb) and later on there’s no “bin” direcrtory (line 144ff)
>         *   README.md: Should we link to downloads at the domain tsfile.org 
> (Line 156)
>         *   README.md: Could not build client due to renaming (used “client” 
> instead of “iotdb-cleient” (Lines 201ff)
>         *   README.md: Stopped validating the content in detail after being 
> able to login to the local server with the cli :-)
>         *   RELEASE_NOTES: Just saying it’s incompatible with 0.7.0 is a 
> little frustrating as someone using it will have to find out the changes 
> himself … that can frustrate people.
>      *   RAT check results OK
>      *   Search for SNAPSHOT:
>         *   Dockerfile references SNAPSHOT
>         *   Documentation references SNAPSHOTS
>            *   docs/Documentation-CHN/UserGuide/8-Tools-Grafana.md
>            *   docs/Documentation/UserGuide/8-Tools-Grafana.md
>            *   grafana/readme.md
>            *   grafana/readme_zh.md
>         *   Module “hadoop” references parent in version “0.8.1-SNAPSHOT”
>   *   Bin bundle:
>      *   Unpacking in the same directory wasn’t possible as it tries to 
> unpack in the same directory as the source-release …
>      *   LICENSE-binary, NOTICE-binary, README.md, RELEASE_NOTES.md exist in 
> binary bundle: OK (However I would prefer them to be called LICENCE and 
> NOTICE as tools like Nexus check for contents of the default names … it will 
> not find the ones with the “-binary” suffix)
>      *   check the contents of LICENSE-binary, NOTICE-binary, README.md, 
> RELEASE_NOTES.md
>         *   LICENSE-binary: The binary doesn’t contain any source files (… 
> therefore mentioning the Hive files can be removed
>         *   LICENSE-binary: The binary doesn’t contain the maven-wrapper … 
> therefore this mention can be removed
>         *   LICENSE-binary: The binary release doesn’t contain any binary 
> files (no jars etc.) therefore I don’t think we need to technically list 
> anything (But I guess it’s more an issue that there is no jar in there … )
>         *   NOTICE-binary: Same year issue as with the Source NOTICE
>         *   NOTICE-binary: As the binary distribution doesn’t seem to contain 
> any binary content, I can’t really verify this
>         *   README.md: Can’t verify as the binary distribution doesn’t work
>         *   RELEASE_NOTES.md: Same issues as in the source bundle
> 
> 
> 
> 
> Am 27.07.19, 09:10 schrieb "Jialin Qiao" <[email protected]>:
> 
> 
> 
>     Hi,
> 
> 
> 
>     Thanks, I submit a PR[1] to update the copyright of MIT and BSD licenses.
> 
> 
> 
>     The licenses and related software licenses are as follows (I update the 
> copyright according to these urls.):
> 
> 
> 
>     MIT License
> 
>     ------------
> 
>     org.slf4j:slf4j-api [2]
> 
>     me.tongfei:progressbar:0.7.3 [3]
> 
> 
> 
>     BSD 2-Clause
> 
>     ------------
> 
>     jline:jline:2.14.5 [4]
> 
> 
> 
>     BSD 3-Clause
> 
>     ------------
> 
>     org.antlr:antlr-runtime:3.5.2 [5]
> 
> 
> 
> 
> 
>     [1] https://github.com/apache/incubator-iotdb/pull/318/files
> 
>     [2]  https://github.com/qos-ch/slf4j/blob/master/slf4j-api/LICENSE.txt
> 
>     [3]  https://github.com/ctongfei/progressbar/blob/master/LICENSE
> 
>     [4] https://jline.github.io/jline2/license.html
> 
>     [5] https://www.antlr.org/license.html
> 
> 
> 
>     Best,
> 
>     --
> 
>     Jialin Qiao
> 
>     School of Software, Tsinghua University
> 
> 
> 
>     乔嘉林
> 
>     清华大学 软件学院
> 
> 
> 
>     > -----原始邮件-----
> 
>     > 发件人: "Justin Mclean" <[email protected]>
> 
>     > 发送时间: 2019-07-27 11:59:35 (星期六)
> 
>     > 收件人: [email protected]
> 
>     > 抄送:
> 
>     > 主题: Re: [VOTE] Apache IoTDB (Incubating) 0.8.0 RC1
> 
>     >
> 
>     > Hi,
> 
>     >
> 
>     > Thanks for fixing all of those minor things.
> 
>     >
> 
>     > >> - Most permissive licenses say the full text of the license needs to 
> be included, that includes the copyright line for BSD and MIT licensed 
> software, I’m not sure that have generic license test in license covers that.
> 
>     > >
> 
>     > > Actually, we have a "licenses" folder under the root which contains 
> full text of the licenses.
> 
>     >
> 
>     > Except it doesn’t have the actual licenses fro each bit of software 
> just some generic ones. With ALv2 it doesn’t;t matter, but with BSD and MIT 
> it does due to the copyright line.
> 
>     >
> 
>     > Thanks,
> 
>     > Justin
> 
> 

Reply via email to