Hi, +1 (binding)
I checked: - incubating in artefact names - DISCLAIMER exists - LICENSE is good - NOTICE may include a little too much text. I not seen an export control placed in NOTICE before, and you only need to include the bit from Hive notice that are relevant [1] - All source files have ASF headers. However this file [4] incorrectly has an ASF header. It’s 3rd party software and should not use the ASF header. - No unexpected binary files - Can compile from source One minor thing in license is this path "./mvn/wrapper/MavenWrapperDownloader.java” should be "./.mvn/wrapper/MavenWrapperDownloader.java" In the README.md - Under "Installation from source code” it point the user to GitHub. The user should be pointed to the projects download page, we don’t want to encourage users to use unreleased software. - The text displayed under "If successful, you will see the the following text in the terminal:” is not correct - The instruction for compiling are not correct “mvn XXX -pl iotdb-cli” and “mvn XXX -pl iotdb” don’t work. - The script to start and stop the server have incorrect paths When starting the server I get this error, but I assume that just my setup or environment. Can someone else confirm that once compiled the source release they can start the server? Error: Could not find or load main class org.apache.iotdb.db.service.IoTDB For the binary convenience release: - The binary notice has way too much information in it. For instance you only need to include the bit from Hive notice that are relevant [1], logbook [2] has no notice file so there no need to include anything about it in the NOTICE file [3]. There no need to mention licensing information, that goes in LICENCE - Most permissive licenses say the full text of the license needs to be included, that includes the copyright line for BSD and MIT licensed software, I’m not sure that have generic license test in license covers that. Thanks, Justin 1. https://github.com/apache/hive/blob/master/NOTICE 2. https://github.com/qos-ch/logback 3. http://www.apache.org/dev/licensing-howto.html#mod-notice 4. ./.mvn/wrapper/MavenWrapperDownloader.java
