Hi, +1 (binding).
Thanks for pointing out the issues @Justin. Is there anything that we need to modify? Good work! @Jialin. Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Jialin Qiao <[email protected]> 于2019年7月27日周六 上午11:16写道： > Hi, > > +1 (binding) > > > I fixed the problems that Justin mentioned in the PR [1], which is already > merged into rel/0.8 and cherry-picked to master. The followings are my > modifications: > > > - NOTICE may include a little too much text. I not seen an export > control placed in NOTICE before, and you only need to include the bit from > Hive notice that are relevant [1] > > fixed, and the export control notice is removed. > > > - All source files have ASF headers. However this file [4] incorrectly > has an ASF header. It’s 3rd party software and should not use the ASF > header. > > removed the license and ASF header > > > In the README.md > > - Under "Installation from source code” it point the user to GitHub. The > user should be pointed to the projects download page, we don’t want to > encourage users to use unreleased software. > > I add the projects download url. > > > - The text displayed under "If successful, you will see the the > following text in the terminal:” is not correct > > fixed > > > - The instruction for compiling are not correct “mvn XXX -pl iotdb-cli” > and “mvn XXX -pl iotdb” don’t work. > > fixed > > > - The script to start and stop the server have incorrect paths > > fixed > > > When starting the server I get this error, but I assume that just my > setup or environment. Can someone else confirm that once compiled the > source release they can start the server? > > Error: Could not find or load main class > org.apache.iotdb.db.service.IoTDB > > not reproduced, may be it is caused by the above incorrect path and > commands. Now you can try again. > > > For the binary convenience release: > > - The binary notice has way too much information in it. For instance you > only need to include the bit from Hive notice that are relevant [1], > logbook [2] has no notice file so there no need to include anything about > it in the NOTICE file [3]. There no need to mention licensing information, > that goes in LICENCE > > fixed > > > - Most permissive licenses say the full text of the license needs to be > included, that includes the copyright line for BSD and MIT licensed > software, I’m not sure that have generic license test in license covers > that. > > Actually, we have a "licenses" folder under the root which contains full > text of the licenses. > > [1] https://github.com/apache/incubator-iotdb/pull/314 > > > Best, > -- > Jialin Qiao > School of Software, Tsinghua University > > 乔嘉林 > 清华大学 软件学院 > > > -----原始邮件----- > > 发件人: "Justin Mclean" <[email protected]> > > 发送时间: 2019-07-27 07:56:31 (星期六) > > 收件人: [email protected] > > 抄送: > > 主题: Re: [VOTE] Apache IoTDB (Incubating) 0.8.0 RC1 > > > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in artefact names > > - DISCLAIMER exists > > - LICENSE is good > > - NOTICE may include a little too much text. I not seen an export > control placed in NOTICE before, and you only need to include the bit from > Hive notice that are relevant [1] > > - All source files have ASF headers. However this file [4] incorrectly > has an ASF header. It’s 3rd party software and should not use the ASF > header. > > - No unexpected binary files > > - Can compile from source > > > > One minor thing in license is this path > "./mvn/wrapper/MavenWrapperDownloader.java” should be > "./.mvn/wrapper/MavenWrapperDownloader.java" > > > > In the README.md > > - Under "Installation from source code” it point the user to GitHub. The > user should be pointed to the projects download page, we don’t want to > encourage users to use unreleased software. > > - The text displayed under "If successful, you will see the the > following text in the terminal:” is not correct > > - The instruction for compiling are not correct “mvn XXX -pl iotdb-cli” > and “mvn XXX -pl iotdb” don’t work. > > - The script to start and stop the server have incorrect paths > > > > When starting the server I get this error, but I assume that just my > setup or environment. Can someone else confirm that once compiled the > source release they can start the server? > > Error: Could not find or load main class > org.apache.iotdb.db.service.IoTDB > > > > For the binary convenience release: > > - The binary notice has way too much information in it. For instance you > only need to include the bit from Hive notice that are relevant [1], > logbook [2] has no notice file so there no need to include anything about > it in the NOTICE file [3]. There no need to mention licensing information, > that goes in LICENCE > > - Most permissive licenses say the full text of the license needs to be > included, that includes the copyright line for BSD and MIT licensed > software, I’m not sure that have generic license test in license covers > that. > > > > Thanks, > > Justin > > > > 1. https://github.com/apache/hive/blob/master/NOTICE > > 2. https://github.com/qos-ch/logback > > 3. http://www.apache.org/dev/licensing-howto.html#mod-notice > > 4. ./.mvn/wrapper/MavenWrapperDownloader.java >
