Hi,

+1 (binding)

I checked:

Binary release:
has NOTICE, LICENSE and DISCLAIMER
Start server (ok)
Start client (ok)
The version printed in client is 0.8.1 (ok)
compatible with 0.8.0, both client-0.8.1 with server-0.8.0 and client-0.8.0 
with server-0.8.1
Example statements are as follow:

```
SET STORAGE GROUP TO root.turbine;
CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=FLOAT, ENCODING=RLE;
insert into root.turbine.d1(timestamp,s0) values(1,24.5);
select * from root;
```

Source release:
has NOTICE, LICENSE and DISCLAIMER
mvn clean package (ok)
test all passed on mac os + jdk1.8(ok)

minor issue: 

filters in TsFileRead in the example of tsfile module are not compatible with 
the file written by TsFileWrite

Best,
--
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院

> -----原始邮件-----
> 发件人: "Xiangdong Huang" <[email protected]>
> 发送时间: 2019-10-05 19:02:47 (星期六)
> 收件人: [email protected]
> 抄送: 
> 主题: [VOTE] Apache IoTDB 0.8.1 (incubating) RC2 release
> 
> Hi all,
> 
> Now I open a new ticket for Apache IoTDB (incubating) 0.8.1 RC2, which fixs
> some issues comparing with RC1. You can find the details at the end of this
> email.
> 
> Apache IoTDB (incubating) 0.8.1 is a bug-fix version from 0.8.0. You can
> get its mainly changes from [5].
> 
> Apache IoTDB (Incubating) 0.8.1 has been staged under [2] and it’s time to
> vote
> on accepting it for release.  All Maven artifacts are available under [1].
> If approved we will seek final release approval from the IPMC.
> Voting will be open for 72hr.
> 
> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> are required to pass.
> 
> Release tag: release/0.8.1
> Hash for the release tag: 37b213b6ab6fc8ca13ab60f21dff099042a0e295
> 
> Per [3] "Before voting +1 PMC/PPMC members are required to download
> the signed source code package, compile it as provided, and test
> the resulting executable on their own platform, along with also
> verifying that the package meets the requirements of the ASF policy
> on releases."
> 
> You can achieve the above by following [4].
> 
> [ ]  +1 accept (indicate what you validated - e.g. performed the non-RM
> items in [4])
> [ ]  -1 reject (explanation required)
> 
> 
> Difference with RC1:
> 
> - PGP signing: there is no established trust chain to any other Apache ...
> - Running IoTDB Server according to information in README.md: MINOR I am
> using OpenJDK 13 and I get an error message that IoTDB only runs on Java 8
> and 11 ... this sort of contradicts the README which states X >= 1.8
> - I would suggest to add an Apache Header to the ".checkstyle" XML file
> - It seems the Hadoop module still contains SNAPSHOT versions: MINOR
> - Able to run the server and client: MINOR Same finding as with the source
> distribution ... not able to run with OpenJDK 13
> - Major bug: The version printed in client is still 0.8.0
> - NOTICE-binary HIVE shows 2008-2018 while NOTICE HIVE shows 2008-2019.
> (Now they are consistent with the notice file at github.com/apache/hive,
> which says 2008-2018)
> 
> [1] https://repository.apache.org/content/repositories/orgapacheiotdb-1005
> [2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.8.1/rc2
> [3] https://www.apache.org/dev/release.html#approving-a-release
> [4]
> https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release
> [5]
> https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.8.1/rc2/RELEASE_NOTES.md
> 
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
> 
>  黄向东
> 清华大学 软件学院

Reply via email to