Thanks Andi

Apologies for the confusion caused by my use of the word "sample".
I will add the license header to the files and submit a PR shortly.
Of course, I understand that you will want to discuss the PR internally.

Best regards

Peter

On 10/07/18 18:00, Andi Huber (JIRA) wrote:
     [ 
https://issues.apache.org/jira/browse/ISIS-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538953#comment-16538953
 ]

Andi Huber commented on ISIS-1967:
----------------------------------

Thanks Peter,

fair enough, your intent to provide the entire package and not just a sample 
sounds legit to me. Doing this in 2 phases as you propose, is also a good idea.

However, we will certainly discuss internally how to proceed, once we receive 
your initial PR.

Also, please be aware, that you need to add an 'Apache 2.0 License' header to 
any source file provided via a PR.

Kind regards,
  Andi

Add tests from Diffblue Deeptest
--------------------------------

                 Key: ISIS-1967
                 URL: https://issues.apache.org/jira/browse/ISIS-1967
             Project: Isis
          Issue Type: Test
          Components: Core
         Environment: Ubuntu 16.04
            Reporter: Peter
            Priority: Minor
              Labels: newbie, test

[Diffblue|https://www.diffblue.com/] is an Oxford, UK-based start-up which 
develops software to analyse code and automatically generate tests. We have run 
an analysis against the apache-isis repository on github, which has produced 
8891 verified tests. I am proposing to file a PR to add a sample (21) of these 
tests into the Isis repo.


--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to