[
https://issues.apache.org/jira/browse/ISIS-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546083#comment-16546083
]
ASF GitHub Bot commented on ISIS-1967:
--------------------------------------
andi-huber commented on issue #114: ISIS-1967: Add tests from Diffblue Deeptest
URL: https://github.com/apache/isis/pull/114#issuecomment-405473531
Hi Peter!
We now have come to an internal agreement, that we will not accept your PR
into Apache Isis' code base. I'm sorry for that, especially because you surly
have invested quite some time into this.
At least to give you some feedback, the main concerns summarized:
* non intuitive naming of tests, such that a reviewer can hardly tell, what
a test is actually testing
* overwhelming amount of tests, impossible for us to review in its entirety
* we do have a lot of classes that use dependency injection; tests for those
classes are difficult to setup and most likely not covered at all
However, it would be of great value to this project, if you manage to find
any bug with your armada of tests and contribute by telling us, what you've
found.
Kind regards, Andi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add tests from Diffblue Deeptest
> --------------------------------
>
> Key: ISIS-1967
> URL: https://issues.apache.org/jira/browse/ISIS-1967
> Project: Isis
> Issue Type: Test
> Components: Core
> Environment: Ubuntu 16.04
> Reporter: Peter
> Priority: Minor
> Labels: newbie, test
>
> [Diffblue|https://www.diffblue.com/] is an Oxford, UK-based start-up which
> develops software to analyse code and automatically generate tests. We have
> run an analysis against the apache-isis repository on github, which has
> produced 8891 verified tests. I am proposing to file a PR to add a sample
> (21) of these tests into the Isis repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
