[
https://issues.apache.org/jira/browse/ISIS-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547678#comment-16547678
]
ASF GitHub Bot commented on ISIS-1967:
--------------------------------------
petersear commented on issue #114: ISIS-1967: Add tests from Diffblue Deeptest
URL: https://github.com/apache/isis/pull/114#issuecomment-405887998
Thanks Andi
I really appreciate you taking the time to consider my PR and providing
feedback on the tests proposed for inclusion in isis.
We are on the way to resolving some of your concerns:
1. Naming of tests is something we had already identified for improvement
and, in fact, the latest analysis includes these changes.
As an example:
```public void
org_apache_isis_applib_internal_base__Bytes_prepend_001_8ef33eec105cda50()
throws Throwable {```
is now:
```public void prepend1() throws Throwable {```
2. Deeptest software aims to identify all paths through the code and
produces a test for each case. The idea is to maximize coverage and remove the
possibility that an area of code is not covered. This means a large number of
tests will be generated - these are compiled and run by the software with only
those which pass being made available by default. It is not suggested that each
of these is manually inspected because they represent the current working code
and serve to track whether that original behaviour changes in the future (due
to a bug or re-design)
3. We do not currently support dependency injection but we are working on it
and can let you know when it is available.
Thanks again for your time. We would be happy to provide further tests for
your consideration, after the naming and appearance-related changes which have
been made recently, and to discuss any issues remaining you may have.
Best regards
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add tests from Diffblue Deeptest
> --------------------------------
>
> Key: ISIS-1967
> URL: https://issues.apache.org/jira/browse/ISIS-1967
> Project: Isis
> Issue Type: Test
> Components: Core
> Environment: Ubuntu 16.04
> Reporter: Peter
> Priority: Minor
> Labels: newbie, test
>
> [Diffblue|https://www.diffblue.com/] is an Oxford, UK-based start-up which
> develops software to analyse code and automatically generate tests. We have
> run an analysis against the apache-isis repository on github, which has
> produced 8891 verified tests. I am proposing to file a PR to add a sample
> (21) of these tests into the Isis repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
