[
https://issues.apache.org/jira/browse/ISIS-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608086#comment-16608086
]
ASF GitHub Bot commented on ISIS-1979:
--------------------------------------
andi-huber commented on a change in pull request #122: ISIS-1979: Refactor
logging in headless runtime and prevent configuri…
URL: https://github.com/apache/isis/pull/122#discussion_r216133649
##########
File path:
core/log4j/src/main/java/org/apache/isis/core/runtime/logging/IsisLoggingConfigurer.java
##########
@@ -51,11 +51,15 @@ public IsisLoggingConfigurer(Level
rootLoggerLevelIfFallback) {
* The root logging level can also be adjusted using command line
arguments.
*/
public void configureLogging(final String configDirectory, final String[]
args) {
+ configureLoggingWithFile(configDirectory + "/" +
LoggingConstants.LOGGING_CONFIG_FILE, args);
+ }
+
+ public void configureLoggingWithFile(final String configFile, final
String[] args) {
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Integration test logging includes a lot of log events twice.
> ------------------------------------------------------------
>
> Key: ISIS-1979
> URL: https://issues.apache.org/jira/browse/ISIS-1979
> Project: Isis
> Issue Type: Bug
> Components: Archetype: SimpleApp
> Affects Versions: 2.0.0-M1
> Reporter: Andi Huber
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten <[email protected]> [1]
> During the bootstrapping of Isis for the integration test there seem to be
> two appenders. The lines starting with the current time come from the
> appender configured in `logging-integtest.properties`. I was not able to
> understand where the second appender is configured. This is not a big problem
> just a bit distracting.
> [1]
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
