[ 
https://issues.apache.org/jira/browse/JCR-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713099#action_12713099
 ] 

Matej Knopp commented on JCR-1456:
----------------------------------

There is one problem with your patch that I overlooked. You create new 
BasicDataSource every time getDriverDataSource() is called. I think there 
should only be one datasource instance per driverclass/url combo. Otherwise it 
just keeps creating pools.

I can fix this easily but it will take some time. Right now I'm in process of 
getting BundleDbPersistenceManager and subclasses used to borrowing connections 
instead of relying on one shared always being available.

> Database connection pooling
> ---------------------------
>
>                 Key: JCR-1456
>                 URL: https://issues.apache.org/jira/browse/JCR-1456
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Jukka Zitting
>         Attachments: dbcp.patch, dbcp.patch, patch-1456-1.txt, 
> patch-1456-2.txt, patch-1456-3.txt
>
>
> Jackrabbit should use database connection pools instead of a single 
> connection per persistence manager, cluster journal, or database data store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to