[
https://issues.apache.org/jira/browse/JCR-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713171#action_12713171
]
Jukka Zitting commented on JCR-1456:
------------------------------------
> You create new BasicDataSource every time getDriverDataSource() is called.
That's by design. As noted in my previous comment, I think we should replace
ConnectionFactory.getConnection() with ConnectionFactory.getDataSource() and
store a reference to the returned DataSource in the persistence manager.
> I think there should only be one datasource instance per driverclass/url
> combo.
Eventually yes. There the extra configuration parts that you proposed earlier
will come in handy. However I think it's more straightforward if we start with
one DataSource per persistence manager for now. Doing it this way we can keep
the changes nicely localized within a single persistence manager. We can change
the configuration mechanism or introduce some repository-local DataSource
registry later on once the basic pooling functionality is there.
> Database connection pooling
> ---------------------------
>
> Key: JCR-1456
> URL: https://issues.apache.org/jira/browse/JCR-1456
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Jukka Zitting
> Attachments: dbcp.patch, dbcp.patch, patch-1456-1.txt,
> patch-1456-2.txt, patch-1456-3.txt
>
>
> Jackrabbit should use database connection pools instead of a single
> connection per persistence manager, cluster journal, or database data store.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
