[
https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301471#comment-17301471
]
Konrad Windszus commented on JCRVLT-509:
----------------------------------------
Adding a default value from OSGi configuration would require some refactoring.
To be as backwards compatible as possible I would propose to:
# Use {{Boolean}} instead of primitive {{boolean}} in {{ImportOption}}
# Leave the constructor of ImportOptions untouched (i.e. don't inject any OSGi
references which would allow to retrieve the default value)
# Modify {{ImportOption.isStrict()}} to return {{Boolean}} and return {{null}}
in case this has not been set (i.e. default value should be used)
# Check for {{null}} with each call of {{ImportOption.isStrict()}} and fall
back to the OSGi configured default value in that case
> Make DocView import failures fail the whole installation
> --------------------------------------------------------
>
> Key: JCRVLT-509
> URL: https://issues.apache.org/jira/browse/JCRVLT-509
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Affects Versions: 3.4.10
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: 3.4.12
>
>
> Currently all ACL, authorizable and regular node exceptions are caught in
> https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
> and just logged. Afterwards the import of the package just continues. Only
> in case the ImportOptions.setStrict() is set to {{true}} it will lead to a
> PackageException in the end.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
