thomasmueller commented on a change in pull request #294:
URL: https://github.com/apache/jackrabbit-oak/pull/294#discussion_r636081437
##########
File path:
oak-run/src/main/java/org/apache/jackrabbit/oak/run/DataStoreCommand.java
##########
@@ -428,15 +433,20 @@ private static void logCliArgs(String[] args) {
private final NodeStore nodeStore;
private final String[] paths;
private final String[] inclusionRegex;
+ private boolean useDirListing;
public NodeTraverserReferenceRetriever(NodeStore nodeStore) {
- this(nodeStore, null, null);
+ this(nodeStore, null, null, false);
Review comment:
Why not simply enable useDirListing by default?
##########
File path:
oak-run/src/main/java/org/apache/jackrabbit/oak/run/DataStoreCommand.java
##########
@@ -462,11 +472,36 @@ private void binaryProperties(NodeState state, String
path, ReferenceCollector c
private void traverseChildren(NodeState state, String path,
ReferenceCollector collector) {
binaryProperties(state, path, collector);
- for (ChildNodeEntry c : state.getChildNodeEntries()) {
+ for (ChildNodeEntry c : getChildNodeEntries(state)) {
traverseChildren(c.getNodeState(), PathUtils.concat(path,
c.getName()), collector);
}
}
+ private Iterable<? extends ChildNodeEntry>
getChildNodeEntries(NodeState state) {
+ if (useDirListing) {
+ PropertyState dirListing = state.getProperty(PROP_DIRLISTING);
Review comment:
I wonder if this property "dirListing" is already set? Or is this
something we need to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
