mreutegg commented on a change in pull request #294:
URL: https://github.com/apache/jackrabbit-oak/pull/294#discussion_r636124358
##########
File path:
oak-run/src/main/java/org/apache/jackrabbit/oak/run/DataStoreCommand.java
##########
@@ -462,11 +472,36 @@ private void binaryProperties(NodeState state, String
path, ReferenceCollector c
private void traverseChildren(NodeState state, String path,
ReferenceCollector collector) {
binaryProperties(state, path, collector);
- for (ChildNodeEntry c : state.getChildNodeEntries()) {
+ for (ChildNodeEntry c : getChildNodeEntries(state)) {
traverseChildren(c.getNodeState(), PathUtils.concat(path,
c.getName()), collector);
}
}
+ private Iterable<? extends ChildNodeEntry>
getChildNodeEntries(NodeState state) {
+ if (useDirListing) {
+ PropertyState dirListing = state.getProperty(PROP_DIRLISTING);
Review comment:
This is already in use by oak-lucene:
https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.38.0/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/OakDirectory.java#L68
and is the reason to introduce it. See also the description in OAK-9435.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
