mreutegg commented on a change in pull request #294:
URL: https://github.com/apache/jackrabbit-oak/pull/294#discussion_r636127994
##########
File path:
oak-run/src/main/java/org/apache/jackrabbit/oak/run/DataStoreCommand.java
##########
@@ -428,15 +433,20 @@ private static void logCliArgs(String[] args) {
private final NodeStore nodeStore;
private final String[] paths;
private final String[] inclusionRegex;
+ private boolean useDirListing;
public NodeTraverserReferenceRetriever(NodeStore nodeStore) {
- this(nodeStore, null, null);
+ this(nodeStore, null, null, false);
Review comment:
Because it may change behaviour. There may be arbitrary content with
such a property, which then impacts how the tree is traversed. With the new
option you explicitly allow the command to take this short cut and kind of give
your consent that you are aware of the consequences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
