fabriziofortino commented on code in PR #1217:
URL: https://github.com/apache/jackrabbit-oak/pull/1217#discussion_r1397505403


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexWriter.java:
##########
@@ -76,7 +76,7 @@ class ElasticIndexWriter implements 
FulltextIndexWriter<ElasticDocument> {
         // old index until the new one gets enabled) during incremental 
reindexing
         if (this.reindex) {
             try {
-                long seed = UUID.randomUUID().getMostSignificantBits();
+                long seed = indexDefinition.indexNameSeed == 0L ? 
UUID.randomUUID().getMostSignificantBits() : indexDefinition.indexNameSeed;

Review Comment:
   `new Random().nextLong()` might be okay but I don't see advantages compared 
to UUID. In case we want to change this we need to create a separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to