fabriziofortino commented on code in PR #1217: URL: https://github.com/apache/jackrabbit-oak/pull/1217#discussion_r1397512063
########## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/facets/ElasticSecureFacetAsyncProvider.java: ########## @@ -112,16 +111,20 @@ public void endData() { .collect(Collectors.toList()) ) ); - LOG.trace("End data {}", facetsMap); + LOG.trace("End data {}", facets); Review Comment: there is no need for that. [Parameterized logging](https://www.tutorialspoint.com/slf4j/slf4j_parameterized_logging.htm) computes `toString` only when trace is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org