stefan-egli commented on code in PR #1262:
URL: https://github.com/apache/jackrabbit-oak/pull/1262#discussion_r1448783153
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1252,6 +1282,37 @@ public void removeGarbage(final VersionGCStats stats) {
delayOnModifications(timer.stop().elapsed(MILLISECONDS),
cancel);
}
}
+
+ private boolean verify(NodeDocument oldDoc, NodeDocument newDoc,
UpdateOp update) {
Review Comment:
Yes, I think we should compare for all variations there. The _node_ can be
deleted in the old or new state - but it has to be the same, otherwise
`removeGarbage` cleaned up some wrong garbage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
