stefan-egli commented on PR #1262: URL: https://github.com/apache/jackrabbit-oak/pull/1262#issuecomment-1887019854
> think we can even reuse the output of versionStore.getModifiedDocs in collectDetailedGarbage() and pass the documents to collectGarbage() rather than querying the database again. would be possible, agreed. would require to replace the iterator approach with keeping the underlying, full list. possible. not sure if we'd gain a lot though, since MongoDocumentStore has the nodesCache, so we're not fetching again from mongo, most of the time. I think the current iterator approach works somewhat better with larger lists / documents where eg there isn't really much garbage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
