rishabhdaim commented on code in PR #1262:
URL: https://github.com/apache/jackrabbit-oak/pull/1262#discussion_r1448763906
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1252,6 +1282,37 @@ public void removeGarbage(final VersionGCStats stats) {
delayOnModifications(timer.stop().elapsed(MILLISECONDS),
cancel);
}
}
+
+ private boolean verify(NodeDocument oldDoc, NodeDocument newDoc,
UpdateOp update) {
Review Comment:
I thought, _because null would mean that the document has been deleted and
in that case, it doesn't make sense to compare them cause it has already been
gone._
But now I think you are right. Deleted documents can be resurrected or that
commit can be reverted and we do need to compare them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
