On Tuesday, October 22, 2013 03:40:17 PM Phil Coates wrote: > Does anyone have any objections if I make a few changes: > > 1) reformat code style towards more standard K&R-style (basically IDE > autoformat, nothing particularly controversial: e.g. 4 spaces per indent, > opening curly brace on same line, etc.)
Well, it's a despicably ugly layout, but sadly yes, go ahead. I'm inured to it nowadays after using Go's gofmt ... > 2) Use Java 5+ where relevant (e.g. foreach, generics) - maybe even Java 7? *blinks* I thought Eyeball used generics and for-each and that those were present in Java 5. What am I missing? > 3) Remove "unused" code, so things like unnecessary default constructors, > etc. (checking with FindBugs, etc.) Take care -- I find Findbugs rather over-enthusiastic about some things. There's code to be taken out. I see there are still traces of the Repair code (which has been abandoned). It would be nice to set up some kind of review process. What's available with JIRA and friends? Chris -- "I know it was late, but Mountjoy never bothers, /Archer's Goon/ so long as it's the full two thousand words." Epimorphics Ltd, http://www.epimorphics.com Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT Epimorphics Ltd. is a limited company registered in England (number 7016688)
