Ying,

jena-csv is looking good.  Hows the csv2rdf tool coming along?

Using the StageGenerator route is OK; if it were OpExecutor you could do some filtering as well but without a value based index (a general comment about Jena stores - not CSv specific) it wil no tmake a lot of performance difference. There is material in the join engine rewrite "quack" but it's not ready. I don't see any major thing that you've done is not applicable at some later (post-summer) date for someone interested to move it on.

Looking at the time left, there is a couple weeks and then the room for manoeuvre.

I think that the most important thing to get this out to people to use.
do is to release it on the world!

That means:

1/ Documentation for use

"Getting started page"
A page for full details.
A page about the code (?)

2/ An Apache release.

If everyone is OK with this, I suggest that this is a release in it's own right with it's own VOTE, etc etc. It's good expereince to

Take a look at our release process documentation to know what's involved:

https://cwiki.apache.org/confluence/display/JENA/Release+Process

and reply quite soon about whether I'vemissed anything that needs doing before a release and whether this plan works for you. I'm very open to doing something different if you suggest something else. The goal is to get stuff to other people - there can be various different ways to do that.

        Andy

Comments:

I checked out a clean copy

1/ "mvn clean test" and I got a test failure.

------------
Running org.apache.jena.propertytable.TS_PropertyTable
log4j:ERROR Could not read configuration file from URL [file:src/test/resources/log4j.properties]. java.io.FileNotFoundException: src/test/resources/log4j.properties (No such file or directory)
------------
Missing file?


2/ fakign  that file I hthen got some output from the tests:

>1(?x <file:///home/afs/Projects/jena-csv/src/test/resources/test.csv#Town> ?townName) (?x <file:///home/afs/Projects/jena-csv/src/test/resources/test.csv#Population> ?pop) <=1 (?x <file:///home/afs/Projects/jena-csv/src/test/resources/test.csv#Predicate%20With%20Space> "PredicateWithSpace2")

Are there by any chance some stray System.out.println in the code? :-)

3/ I also got some javadoc warnings when packaging.

e.g.
[WARNING] /home/afs/Projects/jena-csv/src/main/java/org/apache/jena/propertytable/PropertyTable.java:45: warning - @param argument "column," is not a parameter name.

4/ Is the test coverage sufficiently complete?

Reply via email to