[ 
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555656#comment-15555656
 ] 

ASF GitHub Bot commented on JENA-576:
-------------------------------------

Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/151
  
    Erm, good/bad news.
    
    1. I can fix the problem @afs  found.
    2. I don't want to, because I realize now that I did this whole PR wrong.
    
    If you read up this page, you'll see where both @afs and I remark that it's 
odd that `HttpClient`s can't be built from extant `HttpClient`s. It took me 
until now to understand why. You can call `build()` on an `HttpClientBuilder` 
as many times as you want for as many clients as you want with the exact same 
config. I should never have rethreaded the call hierarchies with `HttpClient`. 
It should have been `HttpClientBuilder` all the time, all the way down to 
`HttpOp` which, within `exec()`, should build and close a client, leaving the 
builder for infinite reuse.
    
    {sigh}
    
    So in order to do this right, I need to redo a good piece of it. That will 
get rid of a lot of subtle things I had to add in the test code to make this 
work in its current form (should have realized something was wrong). This is 
now my top priority because this saga has gone on too long already (yay 
all-volunteer projects :) ). I will write a further comment when I have an ETA, 
hopefully not long.


> Upgrade Apache HTTP Client to 4.3
> ---------------------------------
>
>                 Key: JENA-576
>                 URL: https://issues.apache.org/jira/browse/JENA-576
>             Project: Apache Jena
>          Issue Type: Dependency upgrade
>          Components: ARQ
>    Affects Versions: Jena 2.11.0
>            Reporter: Rob Vesse
>            Assignee: Rob Vesse
>            Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies 
> on Apache HTTP Client.  Currently we are using 4.2.3 while the latest stable 
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version 
> which may entail some refactoring since there appears to have been some 
> breaking changes across the minor version bump which users have seen in usage 
> - e.g. 
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to