[
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558215#comment-15558215
]
ASF GitHub Bot commented on JENA-576:
-------------------------------------
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/151#discussion_r82504973
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java
---
@@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI, Query query,
String queryString, Http
this.query = query;
this.queryString = queryString;
this.service = serviceURI;
- // Copy the global context to freeze it.
- this.context = new Context(ARQ.getContext());
+ this.context = ARQ.getContext();
--- End diff --
Yeah, I meant to ask about that. That (copying/freezing) the context was
causing tests to fail in
[TestAuth](https://github.com/apache/jena/blob/master/jena-fuseki1/src/test/java/org/apache/jena/fuseki/TestAuth.java#L204),
because those tests involve possibly retrieving a client from the context
inside `QueryEngineHTTP`. (The old form was to retrieve an `HttpAuthenticator`
from the context.) Those tests first built the query object and then put the
config into the context, so it wasn't available at execution, because I made
the retrieval of config from the context happen as late as possible, at query
execution. Would you suggest having it happen earlier, at construction time for
`QueryEngineHTTP`?
> Upgrade Apache HTTP Client to 4.3
> ---------------------------------
>
> Key: JENA-576
> URL: https://issues.apache.org/jira/browse/JENA-576
> Project: Apache Jena
> Issue Type: Dependency upgrade
> Components: ARQ
> Affects Versions: Jena 2.11.0
> Reporter: Rob Vesse
> Assignee: Rob Vesse
> Priority: Minor
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies
> on Apache HTTP Client. Currently we are using 4.2.3 while the latest stable
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version
> which may entail some refactoring since there appears to have been some
> breaking changes across the minor version bump which users have seen in usage
> - e.g.
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
