Hello Maxime, I merged some of your PR. Did you have the opportunity to make tests of nightly build ?
Your feedback is welcome. Thanks Regards On Fri, Jan 13, 2017 at 10:35 AM, Maxime Chassagneux < maxime.chassagn...@gmail.com> wrote: > Hi, > > Pls, could you consider to merge this PR too : > > - PR-241 : Support variable for all JMS messages (bytes, object, ...) and > sources (file, folder) > - PR-240 : Improves JMS component robustness > > Thanks . > > 2017-01-12 21:02 GMT+01:00 Philippe Mouawad <philippe.moua...@gmail.com>: > > > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher < > > felix.schumac...@internetallee.de> wrote: > > > > > Am 12.01.2017 um 20:39 schrieb Philippe Mouawad: > > > > > >> Hello, > > >> What do you think of releasing a 3.2 version ? > > >> > > > I think I said before, that I would like to release often :) > > > > > >> > > >> I see following reasons: > > >> > > >> - There is a regression (See bug 60575) > > >> > > > My fix for 60575 needs tests and review as it changes the contract of > the > > > method getSendParameterValuesAsPostBody. > > > > > I reviewed it , it looks ok to me. > > I'll double check. > > > > > > > > It returned true if there were no parameters (and thus none with a > name). > > > (Or if getPostBodyRaw() is true) > > > > > > After the change it returns only true when there are parameters and > none > > > of those have a name. (Or if getPostBodyRaw() is true). > > > > > > > > > > > > > > > This method is used in POST and PUT as well, but I believe the change > to > > > be correct in both places. too. > > > > > > - We have 9 enhancements and 12 Bug fixes > > >> - Some nice features (at least as a current user I find them > > >> interesting > > >> :-) ): > > >> - More space in UI and simpler look > > >> - Up to date Browser based on javafx > > >> > > > We might have to warn a bit more about the need for javafx (The default > > > java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter > > will > > > start, but the results tree view is missing. > > > > > > > I think in this case we should try to fail in a bit cleaner way > > > > > - Or in response assertion > > >> - Replace feature (partial)+ counting > > >> > > >> Maybe we can integrate before next release: > > >> > > >> - PR-247 > > >> - PR-246 > > >> - PR-245 > > >> - PR-237 > > >> > > >> And upgrade some dependencies: > > >> > > >> - jodd which has a lot of perf enhancements that we use in JMeter > > (for > > >> resources extractions) > > >> - httpcomponents > > >> - maybe more > > >> > > > I would like to link the converted pdf tutorials and maybe do a bit of > > > minor tweaks to the look and feel of the web pages (less shadows). > > > > > > Should the sect-num number of the tutorials be continued from those in > > the > > > usermanual section? > > > > > > > I think so. > > > > > > >> Besides, we did a lot of code changes related to sonar, let's release > > it. > > >> > > >> A last good thing is that we start to release more often. > > >> > > > +1 > > > > > > Felix > > > > > >> > > >> > > > > > > > > > -- > > Cordialement. > > Philippe Mouawad. > > > -- Cordialement. Philippe Mouawad.
