On Tue, 26 Feb 2019 at 10:44, Vladimir Sitnikov <sitnikov.vladi...@gmail.com> wrote: > > Philippe> Although I agree with sebb that not touching layout makes it > easier for us to study and work progressively with this migration. > Philippe> I am not sure we should keep layout AS-IS. > > That's false assumption. > There are tons of tools that can compare files and ignore file movements. > > For instance: > 1) Navigate to https://github.com/apache/jmeter/pull/448/files > 2) Open "javascript development console" (e.g. in Chrome) > 3) Type the following and press enter: $$('div.empty').forEach(function(e) > { e.parentElement.parentElement.style.display='none'; }) > > Voilà! You see just the source diff, and all the renames are hidden.
This is not really comparing the same things. However it does show that there are changes in several source files other than a rename. That should not happen, and would not happen if you only added the files needed to support Gradle with the current layout. > In the same way, `git -M ` in console can ignore "rename only" changes. > So, do you have *technical* reasons for keeping the layout? > > Philippe>What would we loose or have to do additionally if we don't touch > it as least in first migration step > > We will lose MY time, and we will get NOTHING out of it. > As I said above, source comparison is trivial (e.g. even GitHub UI works > for that) > Source layout has nothing to do with comparison of binary artifacts by the > way. > > Vladimir
