sebb> This is not really comparing the same things.

This is fun.

It does compare "current source code snapshot" and "the one that I suggest".
In other words, it provides FULL diff of two code snapshots.

Could you please care to elaborate why you say "not really comparing
the same things"?
Does GitHub diff compare random sources?
Does it add extra diff for no reason?
Does it hide a diff?

Why do you say "not really comparing the same things"?

I'm afraid, you don't have technical grounds here.

sebb>However it does show that there are changes in several source files
sebb>other than a rename.

Build-related files build.gradle.kts are *created*, and they are not "renamed".
Apparently there will be changes to the source code since current code
has ill assumptions on the repository layout.
For instance, JMeterTestUtils walks "../bin/..." kind of directories
in order to find jmeter.properties.
Some of the files will be removed as obsolete (e.g. build.xml,
eclipse-related, some tests, etc).

There are changes, however I don't see the way you to implement it in
another way.
Of course, the approach of finding jmeter.properties begs for
refactoring, however it could be done later.

sebb>That should not happen, and would not happen if you only added the
sebb>files needed to support Gradle with the current layout

Are there volunteers to implement Gradle build script and keep current
directory layout?
If so, please wave a hand.

The only way to persuade me to keep current layout is to provide
technical justification. Period.
I'm all ears.

Other than that, I try to keep layout on the best efforts basis.

Vladimir

Reply via email to