Am 09.06.19 um 11:35 schrieb Vladimir Sitnikov: > Felix> It would be great, if those deletion could be reduced to the > replacement > Felix> of re-quant'ed pngs, but I fear that is just too much work > > Unfortunately, BFG does not support for png quantization, and I'm not that > fond of implementing that > taking into account the amount of comments in this thread. > Going with git filter-branch is not an option because it is extremely slow > at JMeter scale.
No I didn't mean, that the quantization should be done inside of bfg. I wanted to point out, that there were two reasons for png replacement in our history: * Screenshots changed because functionality changed (those would be great to keep in our history) * quant'ing (those would be great to loose from our history) > > Felix >Would it be possible to exclude the xdocs path from css and svg > removal? > > The exact list of removed ids is listed in > https://github.com/vlsi/jmeter-git-cleanup/blob/v1.0.0/clean_fork/deleted-files.txt > Feel free to provide suggestions. That is the file I looked at and found the xdocs references. Other files I think should be kept are: asf-logo.* logo.* (old logo is quite big, but of historical interest IMHO) new-style.css style.css > > Re "css", there are files like bootstrap.css (140K), bootstrap.css.map > (3.8M) which I don't think are crucial. Those are the ones from our report feature. I am not sure, how well old versions of reporting work with "newer" versions of bootstrap. > I think xdocs/css/new-style.css can be kept though. Please :) > It might be a nice idea to download JS dependencies from external > repositories for both site and report. Yes, for future versions of our source, that would be a nice enhancement. > > Felix>tag v2_13 > Felix>warning: CRLF will be replaced by LF in > > Probably you want to add .gitattributes file that would specify which files > are text and which are binary. > I think we could add ".gitattributes" file to the initial Git commit, > however it would make cleanup procedure (for forks) more complicated. > I guess there's no BFG option to add a file. My problem here is, that I sometimes checkout a historic version and can't get away from it, as git complains that the files have changed. Adding .gitattributes on those versions won't help me. Any other way to get my checkout working in such a case? Felix > > Vladimir >
