Philippe> had applied the cleanup procedure on a fork and pushed a PR.

Was that the first cleanup on that fork?
Did you use v2.1.1 script for cleanup?
Note: you can't run cleanup v.2.1.1 in case you used other cleaup scripts
before.

Did you copy blobExecCache directory from cleanup script?
Did you use bfg-1.13.2-vlsi-master-44b5b85.jar?


I tried to migrate a non-bare repository, and I identified that we still
have certain text files stored as CRLF in Git.
I thought we fixed those, however it looks like we still have issues.

It looks like a severe inconvenience (especially for checking out previous
releases).
What do you think if we step back a bit and run one more pass over
historical commits and normalize CRLF vs LF all over the place?

I think I can implement that (I'm going to reuse Ant's implementation), and
hopefully it won't take ages/gigabytes of RAM to process the sources.

Steps to reproduce (macOS):
git clone https://github.com/apache/jmeter jmeter_fromgithub
cd jmeter_fromgithub
git diff # no differences

Open bin/report-template/sbadmin2-1.0.7/dist/js/sb-admin-2.js. This file
happens to be in CRLF format
rm bin/report-template/sbadmin2-1.0.7/dist/js/sb-admin-2.js
git reset --hard
git diff # shows sb-admin-2.js as modified

Alternative steps:
git clone https://github.com/apache/jmeter jmeter_fromgithub
cd jmeter_fromgithub
git diff # no differences

copy jmeter_fromgithub to jmeter_fromgithub2 (e.g. create a new folder and
copy all the files)
git diff # 26 differences, all related to bin/report-template/sbadmin2-1.0.7

Vladimir

Reply via email to