vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432878583
##########
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
##########
@@ -283,32 +285,58 @@ public boolean isErrorDetected() {
* @param sampler {@link HTTPSamplerBase}
* @param request {@link HttpRequestHdr}
*/
- protected void computeSamplerName(HTTPSamplerBase sampler,
- HttpRequestHdr request) {
- String prefix = request.getPrefix();
+ protected void computeSamplerName(HTTPSamplerBase sampler, HttpRequestHdr
request) {
+ String prefix = request.getPrefix(); // ppp
int httpSampleNameMode = request.getHttpSampleNameMode();
if (!HTTPConstants.CONNECT.equals(request.getMethod()) &&
isNumberRequests()) {
if(StringUtils.isNotEmpty(prefix)) {
+ // with a prefix name
Review comment:
I add a comment because "prefix" have 2 significations :
- prefix name
- prefix numbering
This is prefix name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
