[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder

[GitBox]

vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432878825



##########
File path: 
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
##########
@@ -283,32 +285,58 @@ public boolean isErrorDetected() {
      * @param sampler {@link HTTPSamplerBase}
      * @param request {@link HttpRequestHdr}
      */
-    protected void computeSamplerName(HTTPSamplerBase sampler,
-            HttpRequestHdr request) {
-        String prefix = request.getPrefix();
+    protected void computeSamplerName(HTTPSamplerBase sampler, HttpRequestHdr 
request) {
+        String prefix = request.getPrefix(); // ppp

Review comment:
       ppp is "ppp"refix name" i use this string to test (look at the image for 
the description of the modification and the test.
   nnn is "nnn"ame i use this string to test the naming request.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org