vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432879807
##########
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java
##########
@@ -86,30 +75,49 @@ public AbstractSamplerCreator() {
/**
* @return int request number
*/
- protected static int getRequestNumber() {
+ public int getRequestNumber() {
Review comment:
The method need to be public not protected (same package)
This method return value from a static value but i don't see why this method
need to be static.
Other methods are not static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
