milamberspace commented on PR #5812: URL: https://github.com/apache/jmeter/pull/5812#issuecomment-1518607622
> Looks good to me. > > Why did you place the parametrized test in its own test class? Copy/paste from the class "TestSampleCompareTo", what is the best way? > > Instead of re-opening a new PR for each round, you could have pushed to the first PR you opened. That way, the comments on the PR would have been together in one PR. Because I try to play with git rebase without success for merge some commit. > > Not really related to this PR: Line 305 (new counting) in the old code is weird. `paramSplit.length` will never be `1`, if there is an `=` sign in the splitted param and it is not the sole char of that param. paramSplit.length can have value 1 in special case "=value" (no name). This is why my unit test number 3 works (name is init to " ". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
