FSchumacher commented on code in PR #5812:
URL: https://github.com/apache/jmeter/pull/5812#discussion_r1174543606
##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java:
##########
@@ -287,10 +287,16 @@ public static Map<String, String[]> getQueryMap(String
query) {
String[] params = query.split(PARAM_CONCATENATE);
for (String param : params) {
String[] paramSplit = param.split("=");
- String name = decodeQuery(paramSplit[0]);
+ String name = null;
+ boolean validNameAndValue = true;
Review Comment:
With the setting of `name` to `null` and conditionally setting it in case of
a valid value, we can replace this variable `validNameAndValue` with a check
for `name != null` (or more positive `name==null`).
But either way, I think the logic is correct now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
