jungm commented on PR #123: URL: https://github.com/apache/johnzon/pull/123#issuecomment-2003786756
Thanks, I understand a bit more what you want to accomplish now :slightly_smiling_face: Arguably `Cannot invoke "java.io.Writer.write(char[], int, int)" because "this.val$from" is null` can be a bit confusing (a user might think: What is this.val$from suppposed to be? What have I done wrong to make it null?") I do believe renaming this parameter would be enough to clarify what has gone wrong though, adding null guards in the Mapper blows up the code with no real benefit. The exception is thrown immediately and easily debuggable, just not as clear why it is happening right now You want to try going that path? Would also be an awesome opportunity to move the anonymous classes from `org.apache.johnzon.mapper.internal.Streams` into proper classes IMHO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
