rmannibucau commented on PR #123: URL: https://github.com/apache/johnzon/pull/123#issuecomment-2003948812
@jungm maybe let do internal.DelegatingXStream classes (1-1 delegation pattern/decorator) and in `Stream` just override the close by a flush delegation, will enable to "expose" the delegating classes and maintain most of the code there and still prevent anyone to use the "skip the close" impl with an IDE magic trick. > ....code that is literally in a package named *.internal... it is not uncommon to see sun.internal in imports from time to time and then a "fix commit" and 99% of the time is it cause the IDE imported the wrong class and there it could be a big silent issue (leak with its impacts either in mem or ulimit). So I prefer to not assume it. > capturing variables from an "outside class" makes code super hard to read IMHO guess we are not more at that stage, lambdas made it more than common ;). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
