rmannibucau commented on PR #123: URL: https://github.com/apache/johnzon/pull/123#issuecomment-2003838137
+1 to just rename the parameter if it helps, having null there should have been identified way earlier in the chain anyway so shouldn't even be possible in terms of code flow. `requireNonNull` does not look required to me. Side note: one required test is that it ends as a `JsonbException` in `johnzon-jsonb` and not a `NullPointerException` or anything else and that the runtime exception thrown in mapper stays of the same type for backward compat. @jungm no big issue for me to make Streams anonymous classes inner classes but I'd like to avoid to make them surfacing as accessible or root classes, they are 100% dedicated to a particular internal need and should be droppable without caring about backward compat - was why it was done this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
