guess you pushed some commit on master before creating the branch we're not releasing tomorrow so you can sleep before fixing ;)
Romain Manni-Bucau @rmannibucau <https://x.com/rmannibucau> | .NET Blog <https://dotnetbirdie.github.io/> | Blog <https://rmannibucau.github.io/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/en-us/product/java-ee-8-high-performance-9781788473064> Le mer. 2 juil. 2025 à 22:12, Jean-Louis Monteiro <jlmonte...@tomitribe.com> a écrit : > I'm sorry, I just checked my PR and it's still there, but for some reason I > pushed to my branch and to master. > I need to fix this quickly > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Wed, Jul 2, 2025 at 10:08 PM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > Did I push to master? > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Wed, Jul 2, 2025 at 10:01 PM Romain Manni-Bucau < > rmannibu...@gmail.com> > > wrote: > > > >> FYI you do not need to break master build increasing checkstyle nor > adding > >> "record" for tests only (which breaks some IDE) because you can > reproduce > >> it with a @JohnzonRecord > >> > >> Guess we either have to drop java 17 for test classes or upgrade > >> checkstyele now master is broken > >> > >> Romain Manni-Bucau > >> @rmannibucau <https://x.com/rmannibucau> | .NET Blog > >> <https://dotnetbirdie.github.io/> | Blog < > https://rmannibucau.github.io/> > >> | Old > >> Blog <http://rmannibucau.wordpress.com> | Github > >> <https://github.com/rmannibucau> | LinkedIn > >> <https://www.linkedin.com/in/rmannibucau> | Book > >> < > >> > https://www.packtpub.com/en-us/product/java-ee-8-high-performance-9781788473064 > >> > > >> > >> > >> Le mer. 2 juil. 2025 à 19:27, Jean-Louis Monteiro < > >> jlmonte...@tomitribe.com> > >> a écrit : > >> > >> > There it is > >> > > >> > https://github.com/apache/johnzon/pull/132 > >> > -- > >> > Jean-Louis Monteiro > >> > http://twitter.com/jlouismonteiro > >> > http://www.tomitribe.com > >> > > >> > > >> > On Wed, Jul 2, 2025 at 5:32 PM Jean-Louis Monteiro < > >> > jlmonte...@tomitribe.com> > >> > wrote: > >> > > >> > > One more thing > >> > > > >> > > I'd like to change the visibility of the Default visibility of > >> Johnson. > >> > So > >> > > we can inherit from it instead of starting from scratch > >> > > > >> > > -- > >> > > Jean-Louis Monteiro > >> > > http://twitter.com/jlouismonteiro > >> > > http://www.tomitribe.com > >> > > > >> > > Le mer. 2 juil. 2025, 12:50, Jean-Louis Monteiro < > >> > jlmonte...@tomitribe.com> > >> > > a écrit : > >> > > > >> > >> Hi all, > >> > >> > >> > >> Anyone against bumping the java version for the main branch from 11 > >> to > >> > 14 > >> > >> (or even 17)? > >> > >> Currently, Java Record aren't really well managed and I don't think > >> > using > >> > >> Java Reflection to workaround the Java version is the best design. > >> > >> > >> > >> > >> > >> -- > >> > >> Jean-Louis Monteiro > >> > >> http://twitter.com/jlouismonteiro > >> > >> http://www.tomitribe.com > >> > >> > >> > > > >> > > >> > > >
