So, the issues with submodules is that users will have to remember to 'git submodule init' when they do a clone.

Also, if you commit within a submodule, you *then* have to commit in the parent project so that HEAD in the parent includes a reference to the new HEAD in the submodule. That'll bite you a few times.

I'd probably add some magic to build.xml to check if the submodules have been init'd, and do that for the user if required before attempting a build, or anything else meaningful.

Fwiw, I started TorqueBox as a set of 6 repositories in a parent repo. It turned out to be a horrible mess for multi-project development. I ended up merging the repos together, and have been much happier since.

        -Bob


On Dec 15, 2009, at 12:18 PM, Charles Oliver Nutter wrote:

Ok, I'll toss at least bytelist, joni, and jcodings into submodules.
If we wanted to make NetBeans and friends use the src, everyone that
checks out would be required to also load the submodules, so I'm not
sure if that's the way to go or not. If there's a way to make
submodules automatically check out, we might want to do that before we
try to wire into NB or builds.

On Mon, Dec 14, 2009 at 3:07 PM, Vladimir Sizikov <[email protected]> wrote:
Hi folks,

On Mon, Dec 14, 2009 at 8:15 AM, Charles Oliver Nutter
<[email protected]> wrote:
Sergio (serabe) suggested adding ByteList as a submodule in Git. It
seems like a good idea; we could keep them separate repositories, but
still have the source available for debugging. I'm no expert on
submodules, though, so I'm not sure the right way to structure it.

Yeah, the ByteList is pretty hard to use without sources, so having
the source available
might be a plus.

On the other hand, the submodules thing is pretty confusing, and it
seems that, for example, rbx folks moved completely away from them for some reason. Would be good to check with them and get the reasons why.

Well, in our case, it seems, that these submodules are more like extra
bonus, and we're not going to use the sources from submodules in our
build process, we would just have sources available to look at, right?

I've attached a format-patch that adds four submodules for bytelist,
joni, jcodings, and jruby-openssl, the primary set of libraries that
we maintain separately and which are generally necessary for most
users. Let me know what you all think...

Looking at the patch I see that the sources are not attached into our
build process, they just stay there, in modules directory, being there
just for the reference. That looks good.

How about other external projects that I often find a need to look at?
jnr-posix? Ah, drat, jnr-posix is under mercurial.... :)

JRuby launcher for Windows might as well go as submodule...

Thanks,
 --Vladimir

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email




---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email




---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to